I noticed onFilterLongPress is always null 👀. Maybe we could consider removing this argument?

Thanks for pointing that out, I hadn’t noticed it.
I’ll remove the parameter along with the comment below.

Since onItemLongPress is always null, maybe we could consider removing these lines of code.

It seems like this if check might not be necessary. Maybe we could just set isMultiSelectMode = true directly?

I think it might be better to invoke combinedClickable before applying the padding modifier. That way, the ripple effect would behave more properly.

Thanks, that’s really helpful and I learned something!

Hiding the icon entirely when unselected might cause the view width to shift compared to the existing behavior, which could feel janky. Maybe controlling the alpha instead would be smoother.

Along with this, I also locked the chip width while the menu is open, so the dropdown list position no longer shifts horizontally.

I appreciate your effort with this change 🙏🏻, but for this checkmark, we don’t need to control its visibility via alpha. It’s fine to keep the original display logic as it was, since this introduces an unintended visual change.

While I understand the issue of the dropdown menu moving during selection, this implementation is somewhat tricky and unnecessarily increases complexity, so I’d like to avoid that.

It seems that placing the DropdownMenu directly at the same hierarchy level as the FilterChip causes the FilterChip to become the anchor for the menu, which is why this problem occurs.

Wrapping the DropdownMenu in a Box could be a good solution. It might seem a bit unusual, but this way the dropdown’s anchor becomes a stable, empty Box, which keeps its position consistent.

Box {
    FilterChip()
    // stable anchor point for DropdownMenu
    Box {
        DropdownMenu()
    }
}

This is a slightly unconventional approach, but I came up with a way to make DropdownMenuItem respond to long presses. I’m not claiming this method is objectively better, so whether to adopt it is entirely up to you.

By implementing it like this, you can enable long-clicks on DropdownMenuItem without creating a custom menu item. The idea is to overlay a box of the same size on top of the menu item and handle click events there:

Box(
    modifier = Modifier.testTag(DropdownFilterChipTestTagPrefix.plus(item))
) {
    DropdownMenuItem(
        leadingIcon = {
            if (selectedItems.contains(item)) {
                Icon(
                    imageVector = Icons.Default.Check,
                    contentDescription = null,
                )
            }
        },
        text = { Text(itemLabel(item)) },
        onClick = { /* actual click events are handled in the overlayed Box */ },
    )
    Box(
        Modifier
            .matchParentSize()
            .combinedClickable(
                onClick = {
                    onItemSelected(item)
                    if (!isMultiSelectMode) {
                        expanded = false
                    }
                },
                onLongClick = {
                    isMultiSelectMode = true
                    haptics.performHapticFeedback(HapticFeedbackType.LongPress)
                    onItemSelected(item)
                },
            )
    )
}

In short, the top Box intercepts both normal and long clicks, so you don’t need to customize DropdownMenuItem itself.

What do you think?

Actually, I first tried writing it the way you suggested, but I couldn’t get it to work, so I ended up using the current approach.

But with the other feedback helping me tidy up the code, I feel more confident it will work this time.

I’m not sure why, but it seems that adding the following Modifier to the DropdownMenuItem not to the outer Box allows the existing tests to pass without issues:

modifier = Modifier.testTag(DropdownFilterChipTestTagPrefix.plus(item))

Specifying default values for lambda parameters has some downsides: it can make it easy to forget to provide a value, and at a glance it’s not always clear whether a value is actually being passed. Therefore, unless there’s a specific reason, I’d prefer to remove default empty lambdas.